-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use System.Text.Json as a backend for view model serialization #1799
base: main
Are you sure you want to change the base?
Conversation
src/Framework/Framework/Binding/Expressions/BindingDebugJsonConverter.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Binding/Expressions/BindingDebugJsonConverter.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Binding/Expressions/CommandBindingExpression.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/ResourceManagement/ReflectionAssemblyJsonConverter.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/ResourceManagement/ReflectionAssemblyJsonConverter.cs
Outdated
Show resolved
Hide resolved
throw new NotSupportedException(string.Format("resource collection name {0} is not supported", prop.Key)); | ||
} | ||
return repo; | ||
throw new NotImplementedException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask if VS Extension needs this
return rt; | ||
} | ||
throw new NotImplementedException(); | ||
// var rt = new DotvvmRouteTable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask if VS extension needs this.
src/Framework/Framework/Runtime/Tracing/RequestTracingExtensions.cs
Outdated
Show resolved
Hide resolved
* fix debug JsonConverters (must be factories to accomodate derived types) * add charset=utf8 to all returned Content-Types * DiagnosticsRequestTracer.ViewModelSerialized now accepts Func<Stream> * Removed viewmodel_stringification_seconds metric as it is no longer relevant (serialization and stringification are now the same thing) * add some [doc]comments
Just to avoid balooning this monster PR. This specific feature is also likely to be removed, depending on the answer from VS Extension guys.
It is neccessary in order to support IGridViewDataSet type hierarchy. The issue didn't occur before, because we didn't map interface correctly, ignoring inherited properties. It didn't matter, because we never serialized them. Now we can end up serializing interface if DynamicDispatch is disabled. The shadowing allows redefining a property with another property of the same .NET Name with a compatible type.
Not needed anymore, the types are natively supported by the serialized
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
All UI tests are currently passing (on Asp.Net Core), most unit tests pass on both .NET Core and .NET Framework, Owin UI tests do not start because of some assembly version conflicts.
Changes to Samples and UI tests are minimal (only dependency version changes, as this requires System.Text.Json 8):